Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESR91: Basic Authentication doesn't work with ESR91 #1080

Open
rainemak opened this issue Sep 29, 2024 · 1 comment
Open

ESR91: Basic Authentication doesn't work with ESR91 #1080

rainemak opened this issue Sep 29, 2024 · 1 comment
Labels
esr91 Changes required to support Gecko ESR 91

Comments

@rainemak
Copy link
Member

Visiting a site requesting basic auth credentials doesn't work on ESR91. With ESR78 a Silica credential dialog is shown, but with ESR91 "authorization required" HTTP status page is immediately shown.

LOGIN: aWindow: [object Window]
===== asyncPromptAuth called =====
Async prompt key = 2|https://dav.jollamobile.com|Password Required
Adding new prompt to the queue, callback = [xpconnect wrapped nsIAuthPromptCallback]
===== promptAuth called =====
found 0 matching logins.
0 matching logins remain after deduping
LOGIN: Checking popup note.
LOGIN: Popup note: undefined
JavaScript error: resource://gre/modules/Prompter.jsm, line 1291: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIWindowWatcher.openWindow]
CONSOLE message:
[JavaScript Error: "NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIWindowWatcher.openWindow]" {file: "resource://gre/modules/Prompter.jsm" line: 1291}]

@rainemak rainemak added the esr91 Changes required to support Gecko ESR 91 label Sep 29, 2024
@rainemak
Copy link
Member Author

rainemak commented Oct 3, 2024

Based on quick look, it looks that a wrong nsILoginManagerPrompter implementation is getting loaded and hitting then Prompter.jsm that we do not have implemented/used. We have similarly cleared Prompter creation from DownloadPrompter.

I'd think that there are changes in the idls implemented by embedlite-components LoginManagerPrompter that we are missing. Thus, a wrong implementation is loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esr91 Changes required to support Gecko ESR 91
Projects
None yet
Development

No branches or pull requests

1 participant