Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mask password in the log #12

Merged
merged 1 commit into from
Aug 18, 2016
Merged

Mask password in the log #12

merged 1 commit into from
Aug 18, 2016

Conversation

sakama
Copy link
Contributor

@sakama sakama commented Aug 9, 2016

When using user and password options, current plugin shows password string in the log.
I changed the code to show "***" instead of password string.

$ embulk run /path/to/config.yml

2016-08-08 11:13:11.308 +0000 [INFO] (0001:transaction): Getting to download file list
2016-08-08 11:13:15.528 +0000 [INFO] (0001:transaction): add file to the request list: sftp://username:[email protected]/home/username/sample_20160805.csv
2016-08-08 11:13:15.676 +0000 [INFO] (0001:transaction): Using local thread executor with max_threads=16 / tasks=1
2016-08-08 11:13:15.854 +0000 [INFO] (0001:transaction): Using time:timestamp column as the data partitioning key

@sakama sakama force-pushed the mask-password-in-log branch from decce34 to 646bba8 Compare August 17, 2016 08:47
@sakama sakama merged commit f3842fb into master Aug 18, 2016
@sakama sakama deleted the mask-password-in-log branch August 18, 2016 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sakama