add RedisAPL #287
add RedisAPL #287
Conversation
Finally an alternative to SaaS or only dev suggested solutions
🦋 Changeset detectedLatest commit: dbc692e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
|
This PR relies on the APP ID to be passed through the constructor. |
.changeset/honky-dory-fox.md
Outdated
| - `src/APL/redis-apl.test.ts`: Tests for Redis APL | ||
|
|
||
| ### Changed | ||
| - npm run lint changed a lot of files, guess it wasn't ran in a while :) |
There was a problem hiding this comment.
Thanks for a notice, but its not a changelog message and I don't see any linter changes committed, so we can remove this message
src/APL/redis-apl.test.ts
Outdated
| import { RedisAPL } from "./redis-apl"; | ||
|
|
||
| // Obviously, for this test to pass you need to have a docker container running redis :) | ||
| const localRedisServerUrl = new URL("redis://127.0.0.1:6379/1"); |
There was a problem hiding this comment.
Redis address should come from ENV (.env.test can be introduced)
src/APL/redis-apl.test.ts
Outdated
| import { AuthData } from "./apl"; | ||
| import { RedisAPL } from "./redis-apl"; | ||
|
|
||
| // Obviously, for this test to pass you need to have a docker container running redis :) |
There was a problem hiding this comment.
In units tests we will not have Redis available so you need to mock it, otherwise your PR will kill CICD until we rework infrastructure
src/APL/redis-apl.ts
Outdated
| import { APL, AplConfiguredResult, AplReadyResult, AuthData } from "./apl"; | ||
| import { createAPLDebug } from "./apl-debug"; | ||
|
|
||
| const debug = createAPLDebug("UpstashAPL"); |
|
stale, closing |
Will fail tests on PRs / Github actions, as it requires a local redis server obviously. But they pass when I test them :)