From f35986405e066c1c636665969e524fe8c7c9046b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krzysztof=20=C5=BBuraw?= <9116238+krzysztofzuraw@users.noreply.github.com> Date: Mon, 28 Oct 2024 10:38:44 +0100 Subject: [PATCH] fixes after CR --- apps/avatax/README.md | 2 +- apps/avatax/src/env.ts | 2 -- apps/avatax/turbo.json | 1 - 3 files changed, 1 insertion(+), 4 deletions(-) diff --git a/apps/avatax/README.md b/apps/avatax/README.md index 44a0c2455..e2669b5a9 100644 --- a/apps/avatax/README.md +++ b/apps/avatax/README.md @@ -125,7 +125,7 @@ The app has an example environment for `localhost` in `environments/localhost.br > This section refers to apps hosted by Saleor or using REST APL. If you self host AvaTax app you need to write your own logic for updating migration scripts. > See [How to update app webhooks](https://docs.saleor.io/docs/3.x/developer/extending/apps/updating-app-webhooks) for more info. -You need to set `REST_APL_TOKEN` & `REST_APL_ENDPOINT` in our `.env` file first. Set `DANGEROUS_ENABLE_MIGRATION_CONSOLE_LOGGER` to see migration results in your shell. +You need to set `REST_APL_TOKEN` & `REST_APL_ENDPOINT` in our `.env` file first. Test migration with dry run, operation will not modify any data: diff --git a/apps/avatax/src/env.ts b/apps/avatax/src/env.ts index 838a88128..165e2fc9f 100644 --- a/apps/avatax/src/env.ts +++ b/apps/avatax/src/env.ts @@ -27,7 +27,6 @@ export const env = createEnv({ DYNAMODB_LOGS_TABLE_NAME: z.string().optional(), E2E_USER_NAME: z.string().optional(), E2E_USER_PASSWORD: z.string().optional(), - // ENABLE_MIGRATION_CONSOLE_LOGGER: booleanSchema.optional().default("false"), FF_ENABLE_EXPERIMENTAL_LOGS: booleanSchema.optional().default("false"), FILE_APL_PATH: z.string().optional(), MANIFEST_APP_ID: z.string().optional().default("saleor.app.avatax"), @@ -59,7 +58,6 @@ export const env = createEnv({ DYNAMODB_LOGS_TABLE_NAME: process.env.DYNAMODB_LOGS_TABLE_NAME, E2E_USER_NAME: process.env.E2E_USER_NAME, E2E_USER_PASSWORD: process.env.E2E_USER_PASSWORD, - // ENABLE_MIGRATION_CONSOLE_LOGGER: process.env.ENABLE_MIGRATION_CONSOLE_LOGGER, ENV: process.env.ENV, FF_ENABLE_EXPERIMENTAL_LOGS: process.env.FF_ENABLE_EXPERIMENTAL_LOGS, FILE_APL_PATH: process.env.FILE_APL_PATH, diff --git a/apps/avatax/turbo.json b/apps/avatax/turbo.json index d97aeb26b..a29cfb8c2 100644 --- a/apps/avatax/turbo.json +++ b/apps/avatax/turbo.json @@ -16,7 +16,6 @@ "AWS_SECRET_ACCESS_KEY", "DYNAMODB_LOGS_ITEM_TTL_IN_DAYS", "DYNAMODB_LOGS_TABLE_NAME", - "ENABLE_MIGRATION_CONSOLE_LOGGER", "FF_ENABLE_EXPERIMENTAL_LOGS", "FILE_APL_PATH", "MANIFEST_APP_ID",