Unable to rename module labels

[jpblonshine]

Issue

When attempting to rename a module, the system will not allow the save.

Expected Behavior

As an Admin User:

1. Navigate to the admin page
2. Click on Rename Modules
3. Navigate to Project Module
4. Click Pencil to reveal the edit
5. Type in singular and plural module name
6. Click Save
7. Module appears with new name

Actual Behavior

As an Admin User:

1. Navigate to the admin page
2. Click on Rename Modules
3. Navigate to Project Module
4. Click Pencil to reveal the edit
5. Type in singular and plural module name
6. Click Save
7. A blank screen appears

Context

By not being able to rename the module, our users get confused as Project is not a term used in our organization.

Your Environment

SuiteCRM Version: 8.1.2-6
Platform: AWS Debian Linux/Unix
PHP Version 8.0.20
Chrome Version 103.0.5060.114

Error Output from Diagnostic

[Thu Jul 21 16:16:10.615353 2022] [authz_core:error] [pid 686:tid
140262080636672] [client ip_address:57932] AH01630: client denied by server
configuration: /opt/bitnami/phpmyadmin/index.php
[Thu Jul 21 16:34:43.772388 2022] [proxy_fcgi:error] [pid 70105:tid
140262072243968] [client ip_address:58797] AH01071: Got error 'PHP message:
PHP Warning: Undefined array key "error" in
/bitnami/suitecrm/public/legacy/cache/smarty/templates_c/%%4C^4CA^4CA03677%%Renam
eModules.tpl.php on line 51PHP message: PHP Warning: Undefined array key
"dropdown_name" in
/bitnami/suitecrm/public/legacy/cache/smarty/templates_c/%%4C^4CA^4CA03677%%Renam
eModules.tpl.php on line 61PHP message: PHP W [Thu Jul 21 16:34:58.419133 2022]
[proxy_fcgi:error] [pid 70105:tid 140262298846976] [client ip_address:58798]
AH01071: Got error 'PHP message: PHP Fatal error: Uncaught Error: Non-static
method DropDownHelper::saveDropDown() cannot be called statically in
/bitnami/suitecrm/public/legacy/modules/Studio/wizards/RenameModules.php:808
Stack trace:
#0
/bitnami/suitecrm/public/legacy/modules/Studio/wizards/RenameModules.php(366):
RenameModules->changeAppStringEntries()
Press [Enter] to continue:
bitnami/vms#1 /bitnami/suitecrm/pub

[pgorod]

I believe this is a duplicate of salesagility/SuiteCRM#9574

Tell me if there's something different in your case, and we can re-open.

Thanks

[jpblonshine]

I have already added "Static" to the function. I am still unable to get past the blank screen.

Thank you

[pgorod]

Ah. Interesting.

Do you still see the same exact PHP error? I wonder if that one got fixed and now we're tripping on the next obstacle.

EDIT: another thing: is the rest of your SuiteCRM looking ok? Do you see parts missing CSS styles, and "undefined" labels in several places? This would be indicative of permissions issues, which are very common in new installations.

[jpblonshine]

All else in the system seems fine. I do not experience what you are describing.

I ran the diagnostic tool and received the following in errors.
ip_address:50428] AH01071: Got error 'PHP message: PHP Fatal error: Uncaught
Press [Enter] to continue:
Error: Non-static method DropDownHelper::saveDropDown() cannot be called
statically in
/bitnami/suitecrm/public/legacy/modules/Studio/wizards/RenameModules.php:808
Stack trace:
#0
/bitnami/suitecrm/public/legacy/modules/Studio/wizards/RenameModules.php(366):
RenameModules->changeAppStringEntries()
salesagility/SuiteCRM#1 /bitnami/suitecrm/pu

[pgorod]

Thanks. Can you please try changing this one here to public static function ?

https://github.com/salesagility/SuiteCRM/blob/master/modules/Studio/DropDowns/DropDownHelper.php#L110

[Mac-Rae]

Same as #166 ?

[johnM2401]

Hey Folks!

Closing this as it no longer appears to be an issue, tested in 8.2.3 and I'm able to Rename modules in PHP8

Changing Accounts to "renameTest"

8.2.0 appears to contain this fix to the Rename Modules functionality.

If you're still having issues regarding Module Renaming, (or any other issues relating to SuiteCRM8), please don't hesitate to get in touch!