Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README with deasync workaround #49

Merged
merged 3 commits into from
Apr 26, 2019
Merged

Conversation

trevor-bliss
Copy link
Contributor

We need to get rid of this dependency!

Copy link
Member

@jbleyleSF jbleyleSF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left one nit.

README.md Outdated
@@ -38,6 +38,13 @@ npm install --global --production windows-build-tools

If that does not work or you are on a different operating system, follow the instructions in the installation section of the `deasync` [README](https://github.com/abbr/deasync#installation).

If all of the above fail, try pinning the version of `deasync` to the latest release using `yarn`'s "resolutions" entry inside the consuming project's package.json file. This requires using `yarn` instead of `npm` to install and build. Add the following to your package.json and run the `yarn` command from the consuming project root:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It's best to follow "this" with a noun or noun phrase because it can be difficult for the reader to determine what "this" is.
This approach requires using yarn instead of npm...

@trevor-bliss trevor-bliss merged commit d25c562 into master Apr 26, 2019
@trevor-bliss trevor-bliss deleted the tbliss/readme-deasync branch April 26, 2019 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants