Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent createDomain signature #161

Closed
jak3 opened this issue Jan 25, 2018 · 0 comments
Closed

Inconsistent createDomain signature #161

jak3 opened this issue Jan 25, 2018 · 0 comments

Comments

@jak3
Copy link

jak3 commented Jan 25, 2018

There is a typing issue in function createDomain.

The createDomain documentation and implementation differ. Number of arguments are not updated in index.d.ts. Arguments should be as mentioned in the README.md.

README.md createDomain signature

pgm.createDomain( domain_name, type, options )

index.d.ts createDomain signature

 createDomain(domain_name: Name, domain_options: DomainOptionsCreate): void
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant