Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration.modules.test_pip failures on macosx #56342

Closed
Ch3LL opened this issue Mar 10, 2020 · 2 comments
Closed

integration.modules.test_pip failures on macosx #56342

Ch3LL opened this issue Mar 10, 2020 · 2 comments
Assignees
@Ch3LL
Labels
fixed-pls-verify fix is linked, bug author to confirm fix Test-Failure Fix the CI failure ⛈ v3000.1 vulnerable version
Milestone
Approved

Comments

@Ch3LL
Copy link
Contributor

Ch3LL commented Mar 10, 2020

Description of Issue

These tests are failing on mac 10.13 and 10.12 python3:

    integration.modules.test_pip.PipModuleTest.test_chained_requirements__non_absolute_file_path
    integration.modules.test_pip.PipModuleTest.test_issue_4805_nested_requirements
    integration.modules.test_pip.PipModuleTest.test_pip_install_multiple_editables_and_pkgs
    integration.modules.test_pip.PipModuleTest.test_requirements_as_list__non_absolute_file_path
    integration.modules.test_pip.PipModuleTest.test_requirements_as_list_of_chains__cwd_not_set__absolute_file_path
    integration.modules.test_pip.PipModuleTest.test_requirements_as_list_of_chains__cwd_set__absolute_file_path
    integration.modules.test_virtualenv_mod.VirtualenvModuleTest.test_create_defaults
    integration.modules.test_virtualenv_mod.VirtualenvModuleTest.test_site_packages
    integration.states.test_pip_state.PipStateTest.test_issue_2028_pip_installed_state
    integration.states.test_pip_state.PipStateTest.test_issue_2087_missing_pip
    integration.states.test_pip_state.PipStateTest.test_issue_6833_pip_upgrade_pip
    integration.states.test_pip_state.PipStateTest.test_pip_installed_errors
    integration.states.test_pip_state.PipStateTest.test_pip_installed_removed_venv
    integration.states.test_pip_state.PipStateTest.test_pip_installed_specific_env
    unit.states.test_pip_state.PipStateTest.test_install_requirements_parsing
    setUpClass (unit.modules.test_zcbuildout.BuildoutOnlineTestCase)
    setUpClass (unit.modules.test_zcbuildout.BuildoutTestCase)
    setUpClass (unit.states.test_zcbuildout.BuildoutTestCase)

i believe the failures are most likely related since these tests use virtualenv. one thing to note is setuptools just released a new 46 release that could possibly be impacting things. If you find they are not related we can break this out into multiple issues and assign out.

https://jenkinsci.saltstack.com/job/pr-macosxhighsierra-py3/job/master/553/
@Ch3LL Ch3LL added the Test-Failure Fix the CI failure ⛈ label Mar 10, 2020
@Ch3LL Ch3LL added this to the Approved milestone Mar 10, 2020
@Ch3LL Ch3LL added the v3000.1 vulnerable version label Mar 10, 2020
@Ch3LL
Copy link
Contributor Author

Ch3LL commented Mar 10, 2020

ping @garethgreenaway any chance you can take a look here?

@Ch3LL Ch3LL mentioned this issue Mar 11, 2020
Merged
@Ch3LL Ch3LL added the fixed-pls-verify fix is linked, bug author to confirm fix label Mar 13, 2020
@Ch3LL
Copy link
Contributor Author

Ch3LL commented Mar 16, 2020

tests are passing now

@Ch3LL Ch3LL closed this as completed Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ch3LL Ch3LL

Labels
fixed-pls-verify fix is linked, bug author to confirm fix Test-Failure Fix the CI failure ⛈ v3000.1 vulnerable version
Projects
None yet
Milestone
Approved
Development

No branches or pull requests
2 participants
@garethgreenaway @Ch3LL