Fix malformed shadow entries #58423
Merged
Fix malformed shadow entries #58423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
terminalmage
force-pushed
the
malformed-shadow-entry
branch
from
5374ee8 to
e03af8b
Compare
|
Do you mind fixing the merge conflicts |
If a shadow entry for a user has too many (or too few) fields, due to having been hand-edited for some silly reason, this will cause Salt not to be able to successfully run a user.present state (with password argument) against it, as spwd will not be able to retrieve a hash for the user, causing Salt to always think that the password hash still needs changes. This fixes these two cases.
terminalmage
force-pushed
the
malformed-shadow-entry
branch
from
be35797 to
f4757e4
Compare
|
@Ch3LL Merge conflicts are fixed and tests passing |
Ch3LL
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a shadow entry for a user has too many (or too few) fields, due to
having been hand-edited for some silly reason, this will cause Salt not
to be able to successfully run a user.present state (with password
argument) against it, as spwd will not be able to retrieve a hash for
the user, causing Salt to always think that the password hash still
needs changes.
This fixes these two cases.