Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log.error to log.info #62728

Merged
merged 3 commits into from
Sep 22, 2022
Merged

Conversation

cro
Copy link
Contributor

@cro cro commented Sep 21, 2022

What does this PR do?

Changes the ReqServer clients and ReqServer workers log message from error level to info level.

What issues does this PR fix or reference?

No particular issue.

Previous Behavior

These were logged like this:

2022-09-20 23:50:31,018 [salt.transport.zeromq:328 ][ERROR   ][1218] ReqServer clients tcp://0.0.0.0:4506
2022-09-20 23:50:31,019 [salt.transport.zeromq:330 ][ERROR   ][1218] ReqServer workers ipc:///var/run/salt/master/workers.ipc

This concerned some customers upgrading to 3005 that something might be amiss.

New Behavior

2022-09-20 23:50:31,018 [salt.transport.zeromq:328 ][INFO   ][1218] ReqServer clients tcp://0.0.0.0:4506
2022-09-20 23:50:31,019 [salt.transport.zeromq:330 ][INFO   ][1218] ReqServer workers ipc:///var/run/salt/master/workers.ipc

Remove this section if not relevant

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@cro cro requested a review from a team as a code owner September 21, 2022 15:44
@cro cro requested review from dwoz and removed request for a team September 21, 2022 15:44
whytewolf
whytewolf previously approved these changes Sep 21, 2022
changelog/62678.added Outdated Show resolved Hide resolved
waynew
waynew previously approved these changes Sep 22, 2022
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving conditionally on the .fixed instead of .added 🙃

@Ch3LL Ch3LL dismissed stale reviews from waynew and whytewolf via f29ffc8 September 22, 2022 17:20
@Ch3LL Ch3LL merged commit 9525881 into saltstack:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants