-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3006.x] Remove the clr.AddReference
call, it is unneeded
#64339
Merged
s0undt3ch
merged 5 commits into
saltstack:3006.x
from
MKLeb:hotfix/remove-clr-add-reference
May 29, 2023
Merged
[3006.x] Remove the clr.AddReference
call, it is unneeded
#64339
s0undt3ch
merged 5 commits into
saltstack:3006.x
from
MKLeb:hotfix/remove-clr-add-reference
May 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
Remove the
[master] Remove the May 23, 2023
clr.AddReference
command, it is causing problems when testing extensions clr.AddReference
command, it is causing problems when testing extensions
MKLeb
force-pushed
the
hotfix/remove-clr-add-reference
branch
from
May 24, 2023 15:54
1a3b34d
to
0ac57e1
Compare
salt-project-bot-prod-environment
bot
changed the title
[master] Remove the
[3006.x] Remove the May 24, 2023
clr.AddReference
command, it is causing problems when testing extensions clr.AddReference
command, it is causing problems when testing extensions
… assuming there is always one interface
MKLeb
changed the title
[3006.x] Remove the
[3006.x] Remove the May 25, 2023
clr.AddReference
command, it is causing problems when testing extensions clr.AddReference
call, it is causing problems when testing extensions
MKLeb
changed the title
[3006.x] Remove the
[3006.x] Remove the May 25, 2023
clr.AddReference
call, it is causing problems when testing extensions clr.AddReference
call, it is unneeded
twangboy
approved these changes
May 29, 2023
s0undt3ch
reviewed
May 29, 2023
s0undt3ch
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See title
Tested to see that we still get the same network interfaces before and after this patch.
Change suggested by @twangboy.
Previous Behavior
Illegal Characters in PATH
New Behavior
Legal characters in path
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes