Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3006.x] Remove the clr.AddReference call, it is unneeded #64339

Merged
merged 5 commits into from
May 29, 2023

Conversation

MKLeb
Copy link
Contributor

@MKLeb MKLeb commented May 23, 2023

What does this PR do?

See title

Tested to see that we still get the same network interfaces before and after this patch.

Change suggested by @twangboy.

Previous Behavior

Illegal Characters in PATH

New Behavior

Legal characters in path

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@MKLeb MKLeb requested a review from a team as a code owner May 23, 2023 21:59
@MKLeb MKLeb requested review from cmcmarrow and removed request for a team May 23, 2023 21:59
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title Remove the clr.AddReference command, it is causing problems when testing extensions [master] Remove the clr.AddReference command, it is causing problems when testing extensions May 23, 2023
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 00:08 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 00:08 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 00:08 — with GitHub Actions Inactive
@MKLeb MKLeb force-pushed the hotfix/remove-clr-add-reference branch from 1a3b34d to 0ac57e1 Compare May 24, 2023 15:54
@MKLeb MKLeb changed the base branch from master to 3006.x May 24, 2023 16:05
@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title [master] Remove the clr.AddReference command, it is causing problems when testing extensions [3006.x] Remove the clr.AddReference command, it is causing problems when testing extensions May 24, 2023
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 19:42 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 19:42 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 19:43 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 19:43 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 19:56 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 20:07 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 20:54 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 20:54 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 20:54 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 20:54 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 20:55 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 20:55 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 21:27 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 21:27 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 21:27 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 21:27 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 21:28 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 21:28 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 22:33 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 22:33 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 22:34 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 22:37 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 22:50 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 22:54 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 23:51 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 23:51 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 23:51 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 23:51 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 23:51 — with GitHub Actions Inactive
@MKLeb MKLeb temporarily deployed to ci May 24, 2023 23:51 — with GitHub Actions Inactive
@MKLeb MKLeb changed the title [3006.x] Remove the clr.AddReference command, it is causing problems when testing extensions [3006.x] Remove the clr.AddReference call, it is causing problems when testing extensions May 25, 2023
@MKLeb MKLeb changed the title [3006.x] Remove the clr.AddReference call, it is causing problems when testing extensions [3006.x] Remove the clr.AddReference call, it is unneeded May 25, 2023
@s0undt3ch s0undt3ch merged commit 8016a09 into saltstack:3006.x May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants