Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] salt-minion pkg.* tasks fail if only dnf5 is present, not dnf #64532

Closed
limburgher opened this issue Jun 22, 2023 · 3 comments · Fixed by #64675
Closed

[FEATURE REQUEST] salt-minion pkg.* tasks fail if only dnf5 is present, not dnf #64532

limburgher opened this issue Jun 22, 2023 · 3 comments · Fixed by #64675
Assignees
Labels
Bug broken, incorrect, or confusing behavior Chlorine v3007.0 dependency underlying Salt dependency issue fedora affects this operating system

Comments

@limburgher
Copy link

limburgher commented Jun 22, 2023

Description
pkg.* uses dnf with no issues for me on Fedora. However, starting with Fedora 39, dnf is obsoleted by dnf5. The command line options are different, so a simple symlink won't work.

Setup

install_fedora_packages:
  pkg.installed:
    - pkgs:
      - vim-enhanced
      - nmap
      - dnf-automatic
      - firewalld

Please be as specific as possible and give set-up details.
Install salt-minion on Fedora 39 instance, start minion, accept key on master.

Steps to Reproduce the behavior
Apply the above sls.

Expected behavior
salt-minion installs packages.

Screenshots

      ID: install_fedora_packages
Function: pkg.installed
  Result: False
 Comment: Error occurred installing package(s). Additional info follows:
          
          errors:
              - Unknown argument "--allowerasing" for command "dnf5". Add "--help" for more information about the arguments.
 Started: 19:45:43.710036
Duration: 1480.451 ms
 Changes:   

Versions Report

Minion is Fedora 39 with same salt version.
Master:

Master:
Salt Version:
          Salt: 3006.1
 
Python Version:
        Python: 3.11.3 (main, May 24 2023, 00:00:00) [GCC 13.1.1 20230511 (Red Hat 13.1.1-2)]
 
Dependency Versions:
          cffi: 1.15.1
      cherrypy: unknown
      dateutil: 2.8.2
     docker-py: Not Installed
         gitdb: 4.0.9
     gitpython: 3.1.30
        Jinja2: 3.0.3
       libgit2: 1.6.3
  looseversion: 1.2.0
      M2Crypto: 0.38.0
          Mako: 1.2.3
       msgpack: 1.0.4
  msgpack-pure: Not Installed
  mysql-python: Not Installed
     packaging: 23.0
     pycparser: 2.20
      pycrypto: 2.6.1
  pycryptodome: 3.17.0
        pygit2: 1.12.0
  python-gnupg: 0.5.0
        PyYAML: 6.0
         PyZMQ: 24.0.1
        relenv: Not Installed
         smmap: 5.0.0
       timelib: Not Installed
       Tornado: 4.5.3
           ZMQ: 4.3.4
 
System Versions:
          dist: fedora 38 
        locale: utf-8
       machine: x86_64
       release: 6.3.8-200.fc38.x86_64
        system: Linux
       version: Fedora Linux 38 

Additional context
With dnf5, the old dnf cannot be installed. This completely breaks any pkg usage on Fedora 39+.
I'm the Fedora Link salt RPM package maintainer.

@limburgher limburgher added Bug broken, incorrect, or confusing behavior needs-triage labels Jun 22, 2023
@welcome
Copy link

welcome bot commented Jun 22, 2023

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@OrangeDog OrangeDog added dependency underlying Salt dependency issue Deprecation fedora affects this operating system labels Jun 26, 2023
@garethgreenaway garethgreenaway added this to the Chlorine v3007.0 milestone Jun 26, 2023
@dmurphy18
Copy link
Contributor

dmurphy18 commented Jun 26, 2023

Related to https://bugzilla.redhat.com/show_bug.cgi?id=2216848
Need to review dnf5 https://dnf5.readthedocs.io/en/latest/changes.html and update Salt code accordingly

Note: this is with Fedora built Salt 3006.1 and not the Salt built 'onedir' version of Salt.

@dmurphy18 dmurphy18 changed the title salt-minion pkg.* tasks fail if only dnf5 is present, not dnf [FEATURE REQUEST] salt-minion pkg.* tasks fail if only dnf5 is present, not dnf Jul 20, 2023
@limburgher
Copy link
Author

Verified, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Chlorine v3007.0 dependency underlying Salt dependency issue fedora affects this operating system
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants