Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] [Package Tests] Windows installers don't keep salt-pip extras directory in previous state #64957

Closed
1 of 10 tasks
MKLeb opened this issue Aug 10, 2023 · 1 comment
Closed
1 of 10 tasks

[BUG] [Package Tests] Windows installers don't keep salt-pip extras directory in previous state #64957

MKLeb opened this issue Aug 10, 2023 · 1 comment
Assignees
@twangboy
Labels
Bug broken, incorrect, or confusing behavior Packaging Related to packaging of Salt, not Salt's support for package management.
Milestone
Sulfur v3006.4

Comments

@MKLeb
Copy link
Contributor

MKLeb commented Aug 10, 2023

Description
When upgrading or downgrading relenv windows packages, the extras-X.Y directory is reset to being empty.

Once fixed, the downgrade tests should be altered to test that this is working correctly in test_salt_downgrade.py.

Setup

  • on-prem machine
  • VM (Virtualbox, KVM, etc. please specify)
  • VM running on a cloud service, please be explicit and add details
    • Tools vm (windows-2022)
  • container (Kubernetes, Docker, containerd, etc. please specify)
  • or a combination, please be explicit
  • jails if it is FreeBSD
  • classic packaging
  • onedir packaging
  • used bootstrap to install

Steps to Reproduce the behavior

  • Install v3006.1
  • salt-pip install pep8
  • Notice that the installed pep8 package is in extras-X.Y
  • Install v3006.2
  • Notice that pep8 is no longer present in any fashion in extras-X.Y

Expected behavior
The extras directory should still have the installed pep8 package
@MKLeb MKLeb added the Bug broken, incorrect, or confusing behavior label Aug 10, 2023
@MKLeb MKLeb added the Packaging Related to packaging of Salt, not Salt's support for package management. label Aug 10, 2023
@MKLeb MKLeb mentioned this issue Aug 10, 2023
Merged
3 tasks
@MKLeb MKLeb added this to the Sulfur v3006.3 milestone Aug 11, 2023
@twangboy twangboy mentioned this issue Aug 23, 2023
Merged
3 tasks
@MKLeb MKLeb changed the title [BUG] Windows installers don't keep salt-pip extras directory in previous state [BUG] [Package Tests] Windows installers don't keep salt-pip extras directory in previous state Aug 28, 2023
@MKLeb MKLeb moved this to In Progress in Test Coverage and Stability Aug 28, 2023
@anilsil anilsil modified the milestones: Sulfur v3006.3, Sulfur v3006.4 Sep 8, 2023
@Ch3LL
Copy link
Contributor

Ch3LL commented Sep 13, 2023

closed by #65038

@Ch3LL Ch3LL closed this as completed Sep 13, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Test Coverage and Stability Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twangboy twangboy

Labels
Bug broken, incorrect, or confusing behavior Packaging Related to packaging of Salt, not Salt's support for package management.
Projects
Test Coverage and Stability
Status: Done
Milestone
Sulfur v3006.4
Development

No branches or pull requests
4 participants
@anilsil @Ch3LL @twangboy @MKLeb