[master] Add support for show_jid to salt-run #65008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salt-project-bot-prod-environment
bot
changed the title
barneysowood
force-pushed
the
show-jid-salt-run
branch
from
b840608 to
782605f
Compare
Ch3LL
previously approved these changes
Aug 18, 2023
Simplify to just use opts in runner to get show_jid. Had thought I'd need to do that so not to print when called via python api or netapi, but doesn't seem to be an issue.
barneysowood
force-pushed
the
show-jid-salt-run
branch
from
820adb2 to
7dd8961
Compare
Ch3LL
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for show_jid to the salt-run cli command to match the behaviour of the salt cli command.
Could have implemented this entirely within
salt/runner.py, but I think it makes sense to not output the JID when Runner is called from other places - happy to get any feedback or alternative suggests on that.Previous Behavior
If
show_jid: Truewas set in master config, runningsalt-runwould not show a JID.New Behavior
salt-runnow printsjid: <jid>Merge requirements satisfied?
Commits signed with GPG?
No