Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] x509_v2 CRL creation confuses local timezone as UTC #65837

Closed
lkubb opened this issue Jan 10, 2024 · 1 comment
Closed

[BUG] x509_v2 CRL creation confuses local timezone as UTC #65837

lkubb opened this issue Jan 10, 2024 · 1 comment
Labels
Bug broken, incorrect, or confusing behavior needs-triage

Comments

@lkubb
Copy link
Contributor

lkubb commented Jan 10, 2024

Description
When creating a CRL with the x509_v2 modules and having a system timezone other than UTC, last_update and next_update are set wrong (they are set via datetime.today instead of datetime.utcnow / datetime.now(tz=timezone.utc).

Setup
irrelevant

Steps to Reproduce the behavior

  • set system timezone to non-UTC
  • create CRL with salt-call x509.create_crl [...] path=$(pwd)/crl.pem
  • salt-call x509.read_crl $(pwd)/crl.pem

Expected behavior
last_update shows current time, next_update current time + days_valid

Screenshots
last_update shows current time + UTC offset, same for next_update

Versions Report
present in all release branches and master

Additional context
Not my own finding, stumbled over a report here: https://groups.google.com/g/salt-users/c/IUUflZz7daQ

@lkubb lkubb added Bug broken, incorrect, or confusing behavior needs-triage labels Jan 10, 2024
@lkubb
Copy link
Contributor Author

lkubb commented May 14, 2024

Closed by #65838

@lkubb lkubb closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior needs-triage
Projects
None yet
Development

No branches or pull requests

1 participant