[BUG] salt-ssh uses hardcoded paths for ssh, scp and ssh-keygen

[ctrix]

Description

salt-ssh uses hardcoded names for the ssh, scp and ssh-keygen binaries.

In our setup we use scp and ssh aliased to a script, as we are signing our keys and this breaks salt-ssh expectations so it doesn't work anymore.

Setup

any on premise setup of salt-ssh, done by the book as described in the documentation.

Steps to Reproduce the behavior

Just install salt-ssh as usual, on any platform.
Then

alias scp='vscp'
alias ssh='vssh'

If the two scripts do not handle the command line params exactly like ssh/scp are doing, salt-ssh will hang.

Expected behavior

salt-ssh should just work

Versions Report

Salt Version:
Salt: 3007.0+0na.127a32e480

Python Version:
Python: 3.12.2 (main, Feb 6 2024, 20:19:44) [Clang 15.0.0 (clang-1500.1.0.2.5)]

Dependency Versions:
cffi: 1.16.0
cherrypy: 18.8.0
dateutil: 2.8.2
docker-py: Not Installed
gitdb: Not Installed
gitpython: Not Installed
Jinja2: 3.1.3
libgit2: Not Installed
looseversion: 1.3.0
M2Crypto: Not Installed
Mako: Not Installed
msgpack: 1.0.7
msgpack-pure: Not Installed
mysql-python: Not Installed
packaging: 23.1
pycparser: 2.21
pycrypto: Not Installed
pycryptodome: 3.19.1
pygit2: Not Installed
python-gnupg: 0.5.2
PyYAML: 6.0.1
PyZMQ: 25.1.2
relenv: Not Installed
smmap: Not Installed
timelib: 0.3.0
Tornado: 6.3.3
ZMQ: 4.3.4

Salt Package Information:
Package Type: Not Installed

System Versions:
dist: darwin 23.3.0
locale: utf-8
machine: arm64
release: 23.3.0
system: Darwin
version: 14.3.1 arm64

====

PR 66205 tries to address this.