Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS]Merge strategies not clearly documented #66733

Open
hramrach opened this issue Jul 22, 2024 · 2 comments
Open

[DOCS]Merge strategies not clearly documented #66733

hramrach opened this issue Jul 22, 2024 · 2 comments
Labels
Documentation Relates to Salt documentation

Comments

@hramrach
Copy link

Description
Merge strategies not clearly documented.

Suggested Fix
Specifics on what is and isn't merged and when

Type of documentation
Salt documentation

Location or format of documentation
https://docs.saltproject.io/en/latest/ref/configuration/master.html#pillar-source-merging-strategy

Additional context
With the default smart strategy I observe that some includes are merged while others not, with no obvious difference between the cases.

The documentation is missing several details:

  • what strategy is selected when by the 'smart' strategy
    • is it possible to tell after the fact which was selected and why
  • in the 'recursive' strategy the example only shows data that is merged, and no data that is not merged. Is it possible that some data is not merged, and what kind?
@hramrach hramrach added Documentation Relates to Salt documentation needs-triage labels Jul 22, 2024
@hramrach hramrach changed the title [DOCS] [DOCS]Merge strategies not clearly documented Jul 22, 2024
@dwoz dwoz removed the needs-triage label Jul 30, 2024
@dwoz
Copy link
Contributor

dwoz commented Jul 30, 2024

@hramrach would you be willing to create a PR for this change?

@dwoz dwoz added this to the Sulfur v3006.10 milestone Jul 30, 2024
@hramrach
Copy link
Author

My problem is that I do not understand what the merge strategies do. With that I cannot write the documentation for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Relates to Salt documentation
Projects
None yet
Development

No branches or pull requests

2 participants