Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade VideoJS to 8.0 or latest stable version #401

Closed
3 of 5 tasks
Dananji opened this issue Feb 9, 2024 · 12 comments
Closed
3 of 5 tasks

Upgrade VideoJS to 8.0 or latest stable version #401

Dananji opened this issue Feb 9, 2024 · 12 comments
Assignees

Comments

@Dananji
Copy link
Collaborator

Dananji commented Feb 9, 2024

Description

Video.js version in Ramp has been pinned to 7.* because it needed Video.js to be that version to use the quality selector plugin used in Ramp.
Ramp was waiting on silvermine/videojs-quality-selector#93 to be merged and released to upgrade Video.js. Now that it has been merged and released @silvermine/videojs-quality-selector can be upgraded from 1.2.4 to 1.3.1 which is the latest version of the plugin. And subsequently Video.js can be upgraded from 7.* to 8.*

Done Looks Like

  • @silvermine/videojs-quality-selector upgraded to 1.3.1
  • videoj.js upgraded to latest stable 8.* version
  • VideoJSFileDownload component's code changes to use extends instead of videojs.extend(..
  • Test all the custom VideoJS components (Progressbar, previous/next canvas buttons, current time display in progress bar, zoom scrubber (magnifying glass), file download) works as expected in all supported browsers and devices
  • Test all the other customization Ramp has implemented on top of native VideoJS functionalities work as expected in all supported browsers and devices: Chrome on Android, Safari on iPhone and iPad, Chrome and Safari on desktop
@joncameron
Copy link
Contributor

This can be worked on after 7.7 release; will require a retest across media player test cases since this will be a large change.

@joncameron
Copy link
Contributor

Most of the work here will be testing; custom components should all be tested for functionality.

@joncameron
Copy link
Contributor

Wait to merge for a new Ramp until 3.0.1 release.

@Dananji
Copy link
Collaborator Author

Dananji commented Apr 22, 2024

This work has been deployed to Ramp demo site

@joncameron
Copy link
Contributor

Need to update test cases in Testomat.io to make sure all of the areas mentioned in this ticket are represented.

@elynema
Copy link

elynema commented Jun 13, 2024

@charumitraravi This should be able to be tested on avalon-dev. The QA specifically covers the custom components that have been added to Ramp (file download is only available on the Ramp demo site). But it would be good to note that all functionality in the player is working, particularly scrubbing as I feel like I have seen some erratic behavior there, but haven't testing systematically yet. This is good preparation as we move into regression to QA this well, and I don't think it has been tested yet.

@charumitraravi
Copy link
Collaborator

charumitraravi commented Jun 20, 2024

Tested all the functionalities in the media player (forward, backward, pause, scrubber movements, captions, magnifying glass,volume,quality,speed , download in ramp site),the hotkeys, and transcripts across the web (chrome,safari) , iphone , ipad (safari) and android(chrome) in different orientations and in full screen .

  • Caption is switched on by default. If I switch off the captions, the selection is not remembered when the player advances to the next section of the item.
  • Transcripts are not getting auto scrolled when the video progresses (eg: 8th section in this item)
  • [iOS] - scrubber movement is not working properly
  • [Android] - pause/play and double tap to full screen is not working properly when clicking on the video. (Happens after the second or third time)
  • [Android] - When transcripts are on auto scroll and the video is played , the page keeps scrolling down without letting the user view the video. This can be replicated by clicking on a phrase in the transcript to play the video from that point.
  • Android , ios - add to playlist and create thumbnail buttons are disabled

@elynema
Copy link

elynema commented Jun 25, 2024

@charumitraravi

  • We have an issue (#5651) to make the caption settings sticky. They are not currently sticky across canvases, so this is not a new bug to report.
  • You said transcripts are not getting auto scrolled when the video progresses. I tested the item you linked, and it is working for me in Chrome. It is a very weird transcript with multiple cues for the same second, so it is scrolling through very fast. Do you have any other examples where this is not working? Or is it in a different browser?
  • For scrubbing on iOS, I can confirm this is not working properly in the native player. This seems to be resolved in Scrubbing doesn't work in native player on demo site #516, which is on the demo site, so we can QA that again once we get a new Ramp build on avalon-dev to see if it is resolved.
  • I'm not able to replicate the issue with pause/play on Android. Have you run into this in Browserstack or on a physical device? I wasn't aware that we supported double tap to full screen. Did this work previously?
  • The transcript auto-scroll should be handled in Don't Scroll Page on Transcript Component Cue Advance #514.
  • The only time I've seen an issue with add to playlist and create thumbnail buttons being disabled is when the media player loads more slowly than usual. That's probably a timing issue for events. Do you have an example that reliably creates problems so I can create an issue? So far, I've only found this one that sometimes doesn't work: https://avalon-dev.dlib.indiana.edu/media_objects/fj236208t

@charumitraravi
Copy link
Collaborator

@elynema

  • As discussed in the meeting, We aren't supporting double tap to full screen. However, there is some flakiness around single tap on screen to pause/ play which is observed on avalon staging as well, which looks like an existing issue.
  • The transcript auto scroll issue is'nt happening anymore on my browser too (which is strange, since i was consistently able to replicate it last week) on the item I specified, and some other items as well. I will keep trying and update on this thread if I am able to find something.
  • Thumbnail buttons and Add to playlist button seems to be resolved now.

@elynema
Copy link

elynema commented Jun 26, 2024

Charu said that the pause/play issue is having when tapping 4-5 times in the same spot on the video on Android. I haven't been able to replicate in Browserstack, so probably won't create an issue for this. She confirmed that we have not historically supported double tap to full screen in Avalon on Android.

Created #5885 to track issues with the add to playlist, thumbnail, and timeline buttons being disabled on mobile.

@elynema
Copy link

elynema commented Jun 26, 2024

@charumitraravi Did you have any additional feedback on the transcript not auto-scrolling to add for further troubleshooting?

I will note that transcript auto-scroll is turned off automatically if you enter a search term in the Transcript tab to search the transcript. This is because we can't have the transcript auto-scroll at the same time the user is navigating search results in the transcript. This is something we'll be working on improving in the future; not sure if it might have caused the problem you're reporting.

@elynema elynema closed this as completed Jun 26, 2024
@charumitraravi
Copy link
Collaborator

@elynema
I don't have any additional feedback to add upon the transcript not auto-scrolling issue. I was only able to replicate the issue when I enter a search term , like you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants