-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade VideoJS to 8.0 or latest stable version #401
Comments
This can be worked on after 7.7 release; will require a retest across media player test cases since this will be a large change. |
Most of the work here will be testing; custom components should all be tested for functionality. |
Wait to merge for a new Ramp until 3.0.1 release. |
This work has been deployed to Ramp demo site |
Need to update test cases in Testomat.io to make sure all of the areas mentioned in this ticket are represented. |
@charumitraravi This should be able to be tested on avalon-dev. The QA specifically covers the custom components that have been added to Ramp (file download is only available on the Ramp demo site). But it would be good to note that all functionality in the player is working, particularly scrubbing as I feel like I have seen some erratic behavior there, but haven't testing systematically yet. This is good preparation as we move into regression to QA this well, and I don't think it has been tested yet. |
Tested all the functionalities in the media player (forward, backward, pause, scrubber movements, captions, magnifying glass,volume,quality,speed , download in ramp site),the hotkeys, and transcripts across the web (chrome,safari) , iphone , ipad (safari) and android(chrome) in different orientations and in full screen .
|
|
|
Charu said that the pause/play issue is having when tapping 4-5 times in the same spot on the video on Android. I haven't been able to replicate in Browserstack, so probably won't create an issue for this. She confirmed that we have not historically supported double tap to full screen in Avalon on Android. Created #5885 to track issues with the add to playlist, thumbnail, and timeline buttons being disabled on mobile. |
@charumitraravi Did you have any additional feedback on the transcript not auto-scrolling to add for further troubleshooting? I will note that transcript auto-scroll is turned off automatically if you enter a search term in the Transcript tab to search the transcript. This is because we can't have the transcript auto-scroll at the same time the user is navigating search results in the transcript. This is something we'll be working on improving in the future; not sure if it might have caused the problem you're reporting. |
@elynema |
Description
Video.js version in Ramp has been pinned to 7.* because it needed Video.js to be that version to use the quality selector plugin used in Ramp.
Ramp was waiting on silvermine/videojs-quality-selector#93 to be merged and released to upgrade Video.js. Now that it has been merged and released
@silvermine/videojs-quality-selector
can be upgraded from 1.2.4 to 1.3.1 which is the latest version of the plugin. And subsequently Video.js can be upgraded from 7.* to 8.*Done Looks Like
@silvermine/videojs-quality-selector
upgraded to 1.3.1videoj.js
upgraded to latest stable 8.* versionextends
instead ofvideojs.extend(..
The text was updated successfully, but these errors were encountered: