Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vtt / srt validation for hours #537

Closed
1 task done
elynema opened this issue Jun 28, 2024 · 2 comments
Closed
1 task done

Update vtt / srt validation for hours #537

elynema opened this issue Jun 28, 2024 · 2 comments
Assignees
@Dananji

Comments

@elynema
Copy link

elynema commented Jun 28, 2024 •
edited by joncameron
Loading

Description

Technically, vtt and srt file formats are required to either have no digits for the hour in the timestamp, or 2 digits. Currently the validation in the Ramp transcript component allows 1 digit in the hour in the timestamp.

Done Looks Like

  • Ramp shows an error if a vtt or srt transcript has a single digit for the hour
@masaball
Copy link
Contributor

masaball commented Jun 28, 2024 •
edited
Loading

amp-demo-amia-transcript (2).txt

Example file

@Dananji Dananji self-assigned this Jul 1, 2024
@Dananji Dananji mentioned this issue Jul 1, 2024
Merged
@Dananji Dananji mentioned this issue Jul 9, 2024
Merged
@joncameron
Copy link
Contributor

https://avalon-dev.dlib.indiana.edu/media_objects/bc386j28j

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dananji Dananji

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Dananji @joncameron @masaball @elynema