Add Lint/RescueWithoutErrorClass

[no-reply]

See: samvera/hyrax#2655 (comment)

[no-reply]

Actually, we want Style/RescueStandardError.

[no-reply]

I expressed some concerns about the Lint/RescueWithoutErrorClass rule here: samvera/hyrax#2655 (comment)

To elaborate. I think it's a pretty common use case for some code (e.g. a Controller) to catch all errors, do some work (log, add a flash message, etc...), and/or reraise with a localized error type.

That cop has been removed, and replaced with Style/RescueStandardError. By default, this cop ensures that rescue StandardError is explicitly specified. My sense is that this is a positive development, and that we should enable the new cop.

[jrochkind]

i agree that rescuing StandardError as long as you are re-raising (original or with a custom module-specific exception class wrapping the original) is both perfectly acceptable and a common thing I do.