Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CircleCI for continuous integration #167

Closed
jrgriffiniii opened this issue May 7, 2019 · 2 comments · Fixed by #168
Closed

Use CircleCI for continuous integration #167

jrgriffiniii opened this issue May 7, 2019 · 2 comments · Fixed by #168
Assignees

Comments

@jrgriffiniii
Copy link
Contributor

Derived from samvera/maintenance#16

@jrgriffiniii
Copy link
Contributor Author

This is only blocked by a consistently failing test:

1) routes to the records controller ids with percent routes them
     Failure/Error: let(:audio) { Audio.new(id: id) }
     Ldp::BadRequest:
     # ./spec/routing/records_routing_spec.rb:6:in `new'
     # ./spec/routing/records_routing_spec.rb:6:in `block (2 levels) in <top (required)>'
     # ./spec/routing/records_routing_spec.rb:8:in `block (2 levels) in <top (required)>'

within rspec ./spec/routing/records_routing_spec.rb:22 # routes to the records controller ids with percent routes them

@jrgriffiniii
Copy link
Contributor Author

This completes for me locally without breaking, I'll proceed by inspecting the difference in FCRepo versions deployed locally and using the Docker Container on CircleCI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants