Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty strings are only removed from multi-value params #75

Closed
phebal opened this issue Mar 3, 2015 · 2 comments
Closed

Empty strings are only removed from multi-value params #75

phebal opened this issue Mar 3, 2015 · 2 comments

Comments

@phebal
Copy link

phebal commented Mar 3, 2015

Cleaning params using HydraEditor::Form#model_attributes doesn't clean single-value params containing empty strings. This is related to samvera-deprecated/sufia#941
@phebal phebal mentioned this issue Mar 3, 2015
Closed
@jcoyne
Copy link
Member

jcoyne commented Mar 3, 2015

@phebal On single values, I want to persist empty strings. Otherwise I can't clear out a value. This is most similar to how rails works with ActiveRecord.

@phebal
Copy link
Author

phebal commented Mar 3, 2015

@jcoyne you're right, I think that changed in Rails 4, I should have checked that. I'll close the corresponding PR, sorry about this.

@phebal phebal closed this as completed Mar 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove blank strings from params phebal/hydra-editor
2 participants
@jcoyne @phebal