Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of tests #118

Closed
elrayle opened this issue Jul 8, 2015 · 3 comments
Closed

Improve performance of tests #118

elrayle opened this issue Jul 8, 2015 · 3 comments
Assignees

Comments

@elrayle
Copy link
Contributor

elrayle commented Jul 8, 2015

Several proposals were made for improving the overall performance of tests.

  • create objects used in tests in a before all block - NOTE: There can be bleed over between tests and multiple failing tests caused by this bleed over. Care needs to be taken in selecting areas of tests where this improvement can be applied.
  • use mockups instead of connecting to Fedora - NOTE: Corresponding improvements need to be made at the ActiveFedora level to have confidence that the removal of this connection won't let failures slip through
  • move edge tests to lower levels (e.g. ActiveFedora) and remove from Hydra:PCDM
@mjgiarlo
Copy link
Member

mjgiarlo commented Jul 8, 2015

👍

@elrayle
Copy link
Contributor Author

elrayle commented Jul 8, 2015

Baseline Performance for basic functions (generated by spec/performance_tests in performance_tests branch)

============================================
 Create 1 collection (10 repetitions)
============================================
 create approach       total time (s)   per object time (s)
--------------------   --------------   -------------------
new                     0.01392198       0.00139220
create                  1.31239271       0.13123927

============================================
 Adding one collection to a collection (10 repetitions)
============================================
    add approach       total time (s)   per object time (s)
--------------------   --------------   -------------------
members <<              7.21745777       0.72174578
collections=            6.98528314       0.69852831
service call            6.90817666       0.69081767

============================================
 Adding one object to a collection (10 repetitions)
============================================
    add approach       total time (s)   per object time (s)
--------------------   --------------   -------------------
members <<              7.06119347       0.70611935
objects=                6.99220324       0.69922032
service call            7.03307724       0.70330772

@elrayle
Copy link
Contributor Author

elrayle commented Jul 8, 2015

My understanding of the difference between new and create is that create = new + persist to Fedora. Can someone confirm that is the only difference?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants