Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try replacing OM with straight Nokogiri #352

Closed
tpendragon opened this issue Sep 10, 2018 · 2 comments
Closed

Try replacing OM with straight Nokogiri #352

tpendragon opened this issue Sep 10, 2018 · 2 comments
Assignees
@barmintor

Comments

@tpendragon
Copy link
Contributor

We're just parsing XML, and not setting anything, so an object model is probably not required. Nokogiri is a well maintained project which is used across the stack.
@jcoyne
Copy link
Member

jcoyne commented Sep 10, 2018

Similar to PR #346

@barmintor barmintor self-assigned this Sep 19, 2018
@mark-dce
Copy link
Contributor

Done in #354

@jrgriffiniii jrgriffiniii mentioned this issue Jun 8, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmintor barmintor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jcoyne @barmintor @tpendragon @mark-dce