Work generic_file validation is wrong

[jcoyne]

https://github.com/projecthydra-labs/hydra-works/blob/master/lib/hydra/works/models/concerns/work_behavior.rb#L41-L42

it is validating that the type of file must be a Works::GenericFile however Sufia will want to provide a "GenericFile" which does not satisfy the current validation:

     ArgumentError:
       each file must be a Hydra::Works::GenericFile

[jcoyne]

See https://travis-ci.org/projecthydra/sufia/jobs/62100942

[jcoyne]

Blocked by #72

[elrayle]

I have a fix for this specific problem. I will create a PR.

[elrayle]

PR #74 fixes this issue. When the PR is merged, this ticket should be closed.

[elrayle]

To validate something is a generic file...

raise ArgumentError, "parent_generic_file must be a works generic file" unless Hydra::Works.generic_file? parent_generic_file

[elrayle]

Ok, with the fuller set of tests, it is apparent the kludge does not work. By using initialize method, it is not fully using the included PCDM:CollectionBehavior. It does not seem to create the members container in Fedora. The most common error:

NoMethodError:
       undefined method `container' for []:ActiveFedora::Associations::ContainerProxy

[kevinreiss]

Why do we want to use:

all_members = self.members.container.to_a

instead of just:

all_members = self.members.to_a

https://github.com/projecthydra-labs/hydra-works/blob/validations/lib/hydra/works/models/concerns/collection_behavior.rb#L44

hydra-pcdm doesn't seem to use .container. It is just doing this as a single line https://github.com/projecthydra-labs/hydra-pcdm/blob/master/lib/hydra/pcdm/models/concerns/collection_behavior.rb#L63-L65.

[elrayle]

Fixed by PR samvera/hydra-pcdm#85