Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine what Storage adapter should support Version for nurax-pg #6234

Closed
no-reply opened this issue Aug 28, 2023 · 3 comments
Closed

Determine what Storage adapter should support Version for nurax-pg #6234

no-reply opened this issue Aug 28, 2023 · 3 comments
Assignees

Comments

@no-reply
Copy link
Contributor

no-reply commented Aug 28, 2023

there's a need to test file version management as implemented in the Hyrax UI (cf. #6211). nurax-pg currently uses the Valkyrie::Storage::Disk adapter, which does not support versions.

determine a path forward for supporting versions on nurax-pg. it's possible we'll want to test this by implementing versioning for the disk adapter, or it may be possible we want to avoid this and implement versioning in a more realistic context (e.g. using shrine).

as a secondary consideration, we may also want to factor in how our choices here will or won't support us when testing in (.koppie),


Some considerations:

  • What will be the recommended storage adapter for new Hyrax applications using Valkyrie?
    • Should nurax-pg be using this adapter, in general?
  • Is an implementation of versioning for the disk adapter going to be a bad idea, in that it will encourage adopters to use a non-robust versioning implementation? (or could it be made robust within a reasonable scope of work?)
  • Does the adapter used need to support manual version creation? (the Hyrax UI does with FCRepo 4)
  • ???
@tpendragon
Copy link
Contributor

Koppie uses Disk, nurax-pg is a different app.

Success Criteria

Someone decides which adapter nurax-pg uses. Is nurax-pg a real production installation that we recommend people install?

Answer the question: What storage adapter will nurax-pg run, and will it support versioning. @dlpierce we're looking for an authoritative answer here.

Questions to answer:

  • Can we implement a versioning enabled disk adapter that's reasonable to maintain?
  • If no, is there a different adapter we should enable in nurax-pg
    • Probably valkyrie-shrine?? Unsure how to generically make versioning work there.
  • Which storage adapters do we expect people to use?

@dlpierce
Copy link
Member

Someone decides which adapter nurax-pg uses. Is nurax-pg a real production installation that we recommend people install?

Nurax PG was set to use disk out of convenience, but that can change. It should be made representative of all the major hyrax features, file versioning included, and provide an example of how a site might be deployed.

Answer the question: What storage adapter will nurax-pg run, and will it support versioning.

Whichever adapter supports versioning so it can be demonstrated. Having a disk backed storage with versioning is likely attractive to implementers who don't need/want to use an object store, but I don't think nurax-pg needs to use a disk storage adapter necessarily.

@rjkati
Copy link

rjkati commented Oct 9, 2023

It is now possible to upload a new version of a fileset to pg.nurax. I am seeing an error message when uploading a new version that doesn't seem to affect functionality. Restoring also does not seem to work. I will open new tickets for these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

5 participants