Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matplotlib listed twice as a dep in setup.py #275

Closed
andersgs opened this issue Jun 22, 2019 · 2 comments
Closed

matplotlib listed twice as a dep in setup.py #275

andersgs opened this issue Jun 22, 2019 · 2 comments

Comments

@andersgs
Copy link
Contributor

Hi.

matplotlib is listed twice as a dependency. Once with no version restrictions, and another with a restriction of at least version 3.1.0. Which one should we use? The relevant section of the setup.py file below.

Thank you for ariba? Happy to make a PR fixing this if you let me know which line is correct. I am assuming the version restricted version.

Best. Anders.

    install_requires=[
        'BeautifulSoup4 >= 4.1.0',
        'biopython',
        'dendropy >= 4.2.0',
        'matplotlib',
        'pyfastaq >= 3.12.0',
        'pysam >= 0.9.1',
        'pymummer<=0.10.3',
        'matplotlib>=3.1.0',
    ],
@kpepper
Copy link
Member

kpepper commented Jun 24, 2019

Hi Anders,

Yes the version got increased in PR 269. >=3.1.0 should be the one to keep.
Feel free to do a PR.

Thanks.

@kpepper
Copy link
Member

kpepper commented Jul 29, 2019

Currently merged to master. Will be in next release.

@kpepper kpepper closed this as completed Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants