You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are incorrect type hints in the code at the link above in the docstring.
Instead of sanic.exceptions.SanicException or Exception it is necessary to specify type[BaseException], but I don't know how to do it adhering to the general style of docstrings.
Perhaps we don't need type hints in docstrings at all, as these are just duplicates.
I will be glad to have any comments, thanks in advance.
Additional context
No response
Is this a breaking change?
Yes
The text was updated successfully, but these errors were encountered:
Link to code
https://github.com/sanic-org/sanic/blob/main/sanic/handlers/error.py#L60
Proposal
There are incorrect type hints in the code at the link above in the docstring.
Instead of
sanic.exceptions.SanicException or Exception
it is necessary to specifytype[BaseException]
, but I don't know how to do it adhering to the general style of docstrings.Perhaps we don't need type hints in docstrings at all, as these are just duplicates.
I will be glad to have any comments, thanks in advance.
Additional context
No response
Is this a breaking change?
The text was updated successfully, but these errors were encountered: