Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sap_general_preconfigure: DNS check ignores A/PTR record insonsistencies #766

Closed
rob0d opened this issue Jun 20, 2024 · 3 comments
Closed

sap_general_preconfigure: DNS check ignores A/PTR record insonsistencies #766

rob0d opened this issue Jun 20, 2024 · 3 comments
Assignees
@berndfinger

Comments

@rob0d
Copy link
Contributor

rob0d commented Jun 20, 2024

Currently the check of A and PTR records in check-dns-name-resolution.yml is set to ignore all errors. There is a message in the log, but as the playbook finishes happily this is easily missed.
I am suggesting to change the three tasks to fail if the test isn't successfull.
Also changed the text of the tasks to make it clearer what is failing.
Pull Request #765 .
@sean-freeman
Copy link
Member

Relates to #743

@rob0d
Copy link
Contributor Author

rob0d commented Jun 21, 2024

Oh yes. I've used slightly different text to yours.

@berndfinger berndfinger self-assigned this Jun 21, 2024
@berndfinger
Copy link
Member

Solved by PR #765.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@berndfinger berndfinger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sean-freeman @rob0d @berndfinger