Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display the property that errored #35

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Feb 13, 2022

Now we have a proper way to identify which properties failed to be validated

image

@codecov-commenter
Copy link

Codecov Report

Merging #35 (37ab83b) into main (34eeb5a) will increase coverage by 0.64%.
The diff coverage is 87.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
+ Coverage   74.97%   75.62%   +0.64%     
==========================================
  Files          36       37       +1     
  Lines         863      886      +23     
  Branches      178      182       +4     
==========================================
+ Hits          647      670      +23     
  Misses        202      202              
  Partials       14       14              
Impacted Files Coverage Δ
src/validators/BaseValidator.ts 67.56% <ø> (ø)
src/validators/ArrayValidator.ts 22.72% <14.28%> (ø)
src/validators/ObjectValidator.ts 94.25% <91.66%> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/lib/errors/CombinedPropertyError.ts 100.00% <100.00%> (ø)
src/validators/DefaultValidator.ts 85.71% <100.00%> (ø)
src/validators/MapValidator.ts 92.30% <100.00%> (ø)
src/validators/RecordValidator.ts 91.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34eeb5a...37ab83b. Read the comment docs.

favna
favna previously approved these changes Feb 14, 2022
src/validators/ArrayValidator.ts Outdated Show resolved Hide resolved
tests/lib/errors/CombinedPropertyError.test.ts Outdated Show resolved Hide resolved
@favna favna merged commit fe188b0 into main Feb 17, 2022
@favna favna deleted the feat/display-property-errors branch February 17, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants