Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tuple #39

Merged
merged 18 commits into from
Mar 2, 2022
Merged

feat: add tuple #39

merged 18 commits into from
Mar 2, 2022

Conversation

imranbarbhuiya
Copy link
Contributor

@imranbarbhuiya imranbarbhuiya commented Feb 24, 2022

add tuple validator

@imranbarbhuiya imranbarbhuiya marked this pull request as ready for review February 24, 2022 18:51
src/validators/TupleValidator.ts Outdated Show resolved Hide resolved
src/validators/TupleValidator.ts Outdated Show resolved Hide resolved
src/validators/TupleValidator.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #39 (2d8dd85) into main (6442f18) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   97.43%   97.49%   +0.06%     
==========================================
  Files          40       41       +1     
  Lines        1051     1079      +28     
  Branches      214      222       +8     
==========================================
+ Hits         1024     1052      +28     
  Misses         23       23              
  Partials        4        4              
Impacted Files Coverage Δ
src/lib/Shapes.ts 100.00% <100.00%> (ø)
src/validators/TupleValidator.ts 100.00% <100.00%> (ø)
src/validators/imports.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6442f18...2d8dd85. Read the comment docs.

favna
favna previously requested changes Feb 25, 2022
src/validators/TupleValidator.ts Outdated Show resolved Hide resolved
@favna favna dismissed their stale review February 26, 2022 08:15

resolved but pending Kyra's comment before approval

@favna favna self-requested a review February 28, 2022 18:30
src/lib/Shapes.ts Show resolved Hide resolved
@favna favna merged commit b7704bf into sapphiredev:main Mar 2, 2022
@imranbarbhuiya imranbarbhuiya deleted the tuple branch March 3, 2022 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants