Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s.union): fix union overrides #62

Merged
merged 3 commits into from
Mar 13, 2022
Merged

fix(s.union): fix union overrides #62

merged 3 commits into from
Mar 13, 2022

Conversation

kyranet
Copy link
Member

@kyranet kyranet commented Mar 12, 2022

The overridden methods were not supposed to nest UnionValidators

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2022

Codecov Report

Merging #62 (c5ec519) into main (708276e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   97.32%   97.33%           
=======================================
  Files          47       47           
  Lines        1235     1238    +3     
  Branches      255      257    +2     
=======================================
+ Hits         1202     1205    +3     
  Misses         28       28           
  Partials        5        5           
Impacted Files Coverage Δ
src/validators/UnionValidator.ts 80.85% <100.00%> (+1.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 708276e...c5ec519. Read the comment docs.

@favna favna merged commit 56e9b19 into main Mar 13, 2022
@favna favna deleted the fix/resolved-union-bugs branch March 13, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants