Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter function to mark C/T and G/A SNPs #30

Open
rcavalcante opened this issue Feb 27, 2020 · 0 comments
Open

Filter function to mark C/T and G/A SNPs #30

rcavalcante opened this issue Feb 27, 2020 · 0 comments

Comments

@rcavalcante
Copy link
Member

rcavalcante commented Feb 27, 2020

Issues to resolve before implementation

  • Which Bioconductor SNP resource to use?
  • Need to reconcile possible differences between GRCh37 and hg19?
  • My understanding is that with hg38, GRCh38 = hg38 so that isn't an issue?
  • Would it be best to put the onus on the user to find GRanges of the SNPs (and possibly wider blacklisted loci) and simply have that as an argument? The function becomes much simpler, but we should still have some documentation for how such a GRanges object might be built.

Function call

filter_loci_by_snps(bs, ...?)

Description

Used after bsseq::read.bismark and before or after filter_loci_by_coverage() to remove loci that contain C to T or G to A SNPs because these are confounding for bisulfite conversion.

Arguments

  • bs a BSseq object that hasn't been subjected to tile_by_windows() or tile_by_regions().
  • ...?

Values

A BSseq object where loci with C/T or G/A SNPs removed.

Tests

Test that SNPs are removed in the destranded and stranded case. This will require slightly altering the test data from #28 to include a SNP or more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant