From 795fe9a878b09b7ecd4625a718afcf56075fa61e Mon Sep 17 00:00:00 2001 From: frostming Date: Thu, 27 Aug 2020 10:50:50 +0800 Subject: [PATCH 1/3] skip invalid python entries --- src/pythonfinder/models/windows.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pythonfinder/models/windows.py b/src/pythonfinder/models/windows.py index ca1a107..fb36a27 100644 --- a/src/pythonfinder/models/windows.py +++ b/src/pythonfinder/models/windows.py @@ -96,7 +96,7 @@ def get_versions(self): py_version = PythonVersion.from_windows_launcher( version_object, name=name, company=company ) - except InvalidPythonVersion: + except (InvalidPythonVersion, AttributeError): continue if py_version is None: continue From 34fcde323bb3b6f39fd073c262657512b2e0555d Mon Sep 17 00:00:00 2001 From: frostming Date: Thu, 27 Aug 2020 11:24:55 +0800 Subject: [PATCH 2/3] add news --- news/89.bugfix.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 news/89.bugfix.rst diff --git a/news/89.bugfix.rst b/news/89.bugfix.rst new file mode 100644 index 0000000..b27dae997 --- /dev/null +++ b/news/89.bugfix.rst @@ -0,0 +1 @@ +Skip invalid entries from Windows registry. From 14e06526a784d8b9383f5bd9e61cbd82d2168018 Mon Sep 17 00:00:00 2001 From: frostming Date: Thu, 27 Aug 2020 14:57:55 +0800 Subject: [PATCH 3/3] ensure paths in path_order are slash-joined. --- src/pythonfinder/models/path.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pythonfinder/models/path.py b/src/pythonfinder/models/path.py index d112386..7a19718 100644 --- a/src/pythonfinder/models/path.py +++ b/src/pythonfinder/models/path.py @@ -302,7 +302,7 @@ def _remove_path(self, path): normalized = normalize_path(current_path) if normalized != target: new_order.append(normalized) - new_order = [p for p in reversed(new_order)] + new_order = [ensure_path(p).as_posix() for p in reversed(new_order)] return attr.evolve(self, path_order=new_order, paths=new_paths) def _setup_asdf(self):