Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lint): support for global settings #1344

Merged
merged 1 commit into from
Apr 13, 2023
Merged

feat(lint): support for global settings #1344

merged 1 commit into from
Apr 13, 2023

Conversation

allanbowe
Copy link
Member

Issue

Closes sasjs/lint#209

Intent

It is now possible to put a .sasjslint file in the user home directory to provide global lint settings.

Implementation

Bumped @sasjs/lint to latest version

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • JSDoc comments have been added or updated.
  • Reviewer is assigned.

It is now possible to put a .sasjslint file in the user home directory to provide global settings.  Closes sasjs/lint#209
@sasjsbot sasjsbot requested a review from medjedovicm April 13, 2023 12:01
@github-actions
Copy link

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 71.55% 3164/4422
🔴 Branches 57.67% 1241/2152
🟡 Functions 72.09% 643/892
🟢 Lines 81.43% 8233/10110

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Show files with reduced coverage 🔻

Reduced coverage

Status Filename Statements Branches Functions Lines
🟡 src/utils/config.ts 57.67% 54.17% 63.79% (+1.72% 🔼) 63.38%
🟢 src/utils/test.ts 84.66% (-1.14% 🔻) 68.12% 77.14% 91.12%
🟢 src/commands/compile/compileSingleFile.ts 95.83% (-2.08% 🔻) 84% (-4% 🔻) 100% 100%

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 15bc127

@allanbowe allanbowe merged commit d6f5dd1 into main Apr 13, 2023
@allanbowe allanbowe deleted the multiroot branch April 13, 2023 18:28
@sasjsbot
Copy link

🎉 This PR is included in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.sasjslint support for multi root workspace
3 participants