Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent release unless npm i reports 0 vulnerabilities #1354

Closed
allanbowe opened this issue Jul 13, 2023 · 2 comments · Fixed by #1373
Closed

prevent release unless npm i reports 0 vulnerabilities #1354

allanbowe opened this issue Jul 13, 2023 · 2 comments · Fixed by #1373
Assignees
@YuryShkoda
Labels
released

Comments

@allanbowe
Copy link
Member

often the CLI dependencies will report vulnerabilities, and whilst these almost never have any actual impact on the CLI, the log does not look presentable.

This issue occurred in the 4.0.0 release (3 medium severity due to tough cookie package), fixed in 4.0.1.

We should have zero vulnerabilities (green) report when installing the CLI using NPM, and the release should fail if this is not the case.
@YuryShkoda YuryShkoda self-assigned this Jul 13, 2023
@YuryShkoda
Copy link
Member

potentially also related to @sasjs/utils

@YuryShkoda YuryShkoda mentioned this issue Aug 29, 2023
Merged
9 tasks
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

🎉 This issue has been resolved in version 4.10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YuryShkoda YuryShkoda

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent release if there are vulnerable dependencies sasjs/cli
2 participants
@allanbowe @YuryShkoda