Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in interpolations in comments #1121

Closed
xzyfer opened this issue Apr 22, 2015 · 2 comments · Fixed by #1136
Closed

Regression in interpolations in comments #1121

xzyfer opened this issue Apr 22, 2015 · 2 comments · Fixed by #1136

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Apr 22, 2015

There are many libraries that depend on this behaviour for things like documentation.

/*
 * <div class="foo #{$foo}" bar="#{$bar}" baz="#{$baz}">
 */

Ruby Sass

/*
 * <div class="foo foo" bar="bar" baz="baz">
 */

Libsass 3.1.0

/*
 * <div class="foo foo" bar="bar" baz="baz">
 */

Libsass 3.2.0-beta.6

/*
 * <div class="foo foo bar=bar baz=baz">
 */

A git bisect shows this regression was introduced in 7877cfa.

Spec added sass/sass-spec#334

@xzyfer
Copy link
Contributor Author

xzyfer commented Apr 25, 2015

@mgreter if you're able to tackle this I think it'll clean up my patch for #1127.

@xzyfer
Copy link
Contributor Author

xzyfer commented Apr 25, 2015

Never mind looks like my patch takes care of this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant