Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Singularity fails to compile with error: "function output-isolation has no parameter named $span". (libSass 3.2.0) #1128

Closed
OnkelTem opened this issue Apr 24, 2015 · 6 comments

Comments

@OnkelTem
Copy link

I hope I selected the correct issue queue for this report.
On the latest libSass (3.2.0) SGS (1.6.2) fails to compile with this error:

Error: libraries/singularity/stylesheets/singularitygs/_api.scss
  59:87  function output-isolation has no parameter named $span

The next code is responsible for this (line marked with *):

  @if $Direction == 'both' or $From == 'left' or ($Direction == 'rtl' and $From == 'opposite') {
      $Left: call('output-#{$output-style}', map-merge($Span-Map, ('direction': left))); /***/
    }

    @if $Direction == 'both' or $From == 'right' or ($Direction == 'ltr' and $From == 'opposite') {
      $Right: call('output-#{$output-style}', map-merge($Span-Map, ('direction': right)));
    }

The function output-isolation is defined like this:

@function output-isolation($Span-Map) {
  ...

Ideas what is going wrong and how to workaround it?

@xzyfer
Copy link
Contributor

xzyfer commented Apr 24, 2015

Hi @OnkelTem thanks for the report.

Unfortunately we're not able to progress on this issue in it's current state. Noone on the Libsass team is familiar with Signularity, nor do we have time to debug their entire code base.

Please supply a copy-pastable snippet of Sass code that produces the error you're encounter. Only then can we begin to understand the actual problem you're encountering.

@OnkelTem
Copy link
Author

Ok, working on this

@xzyfer
Copy link
Contributor

xzyfer commented Apr 24, 2015

Appreciate it @OnkelTem

@Snugug
Copy link

Snugug commented Apr 24, 2015

I happen to know quite a bit about Singularity, and I'm not entirely sure what's going on. I believe the problem is related to argument handling for dynamic call function.

The file in question is here, but I believe the operative lines are L35-47 and L59 where the actual call takes place.

If I were a guessing man, I think the problem is we're passing a map in to the arguments for a dynamic call function and that map is being converted to arguments instead of being passed as a single argument that is a map.

Here is a working SassMeister using Ruby Sass, it'll fail when using the current beta of Libsass (and interestingly works with Libsass 3.1.0) so this should be a regression.

@xzyfer
Copy link
Contributor

xzyfer commented Apr 25, 2015

You're absolutely correct @Snugug. I've opened a new issue to better track this #1133

@xzyfer
Copy link
Contributor

xzyfer commented Apr 26, 2015

This was fixed in #1135 and will be in the next release.

@xzyfer xzyfer closed this as completed Apr 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants