-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested @media rules render different from Ruby SASS #185
Comments
Hmm, looks like Sass does some boolean algebra on nested media queries ... thanks for the report! |
Also with nesting retina media queries inside a width query. This Sassmeister gist illustrates it: if you switch compilers in the control panel you can see how ruby-sass 3.3 combines them correctly but libsass simply writes it out nested: |
the ruby code should be in Query::merge() |
Does someone have a (temporarily) workaround for this problem? |
Hi all, any progress with this? |
I'm going to open a new issue on this, since the second one seems like a different issue. |
Oh shit, totally misread this. Sorry, I thought that was a merge against the original issue above. Sorry, missed that it's never been addressed at all. |
I've started looking into this. It's one of the few major blockers IMHO. |
This fixed via #800 and will be in 3.2. |
I'm very glad this will be fixed with 3.2, this will make it easy to do e.g. retina-specific code inside code blocks for specific responsive sizes. Hoping the next release is finalized soon, any guesses as to when it'll be ready? |
Hi everybody
Nested @media rules are not rendered the same as with Ruby SASS.
Source SCSS File:
Libsass output:
Ruby SASS output:
Although libsass output is valid css3, it's not valid css2.1.
For some more info see: http://stackoverflow.com/a/11747166
Thanks and have a nice day!
The text was updated successfully, but these errors were encountered: