Throws when data && file are null (an edge case)

[am11]

When an empty option set is sent to libsass, it chokes. :)
Same thing happens, when file and data options are empty or null.

//# this is 'node.js interactive console'

require("node-sass").renderSync({file:undefined})
// OR
require("node-sass").renderSync({file:null})
// OR
require("node-sass").renderSync({file:""})
// OR
require("node-sass").renderSync({data:undefined})
// OR
require("node-sass").renderSync({data:""})
// OR
require("node-sass").renderSync({data:"",file:""})
// OR
require("node-sass").renderSync({data:null,file:null})
// OR
require("node-sass").renderSync({data:undefined,file:undefined})
// OR permute undefined and null
// OR
require("node-sass").renderSync({})

// But this properly emits error:
require("node-sass").renderSync({file:"C:/temp/non-existing-path/blah.scss"})
/* returns:
{
  "status": 4,
  "message": "File to read not found or unreadable: C:/temp/non-existent-path/blah.scss"
}*/
// Also this is tolerable:
require("node-sass").renderSync({data:"messing around"})
/* returns:
{
  "status": 1,
  "file": "stdin",
  "line": 1,
  "column": 1,
  "message": "invalid top-level expression"
}*/
// And
require("node-sass").renderSync({data:null, file:"devnull"})
/* returns:
{
  "status": 4,
  "message": "File to read not found or unreadable: devnull"
}*/

Originally reported by @DinisCruz: sass/node-sass#554.

[mgreter]

This should be fixed and you should now get a proper error on the context!

[am11]

Thanks @mgreter! 👍

I will try it now.

[am11]

@mgreter, somehow the errors which were previously returned as JSON are coming as plain text. Is there something changed in sass_context_get_error_json()?

[mgreter]

Nope, this should behave the same as before!

[am11]

After pulling the latest libsass master, it is giving me a plain text error:

require("node-sass").renderSync({data:"messing around"})
source string:1: error: invalid top-level expression

Which was previously producing:

{
  "status": 1,
  "file": "stdin",
  "line": 1,
  "column": 1,
  "message": "invalid top-level expression"
}

And segmentation fault if data is an empty string:

require("node-sass").renderSync({data:""})
Segmentation fault

[am11]

Sorry for the cry-wolf, recompiling fixes it! (crazy things happening today here) :)