Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

str-slice returns incorrect value when last $end-at is omitted #815

Closed
xzyfer opened this issue Jan 7, 2015 · 0 comments · Fixed by #816
Closed

str-slice returns incorrect value when last $end-at is omitted #815

xzyfer opened this issue Jan 7, 2015 · 0 comments · Fixed by #816
Assignees
@xzyfer
Labels
Bug - Confirmed Dev - Test Written
Milestone
3.2

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Jan 7, 2015 

foo {
    foo: str-slice("bar", 1, 2);
    bar: str-slice("bar", 3);
}

expected

foo {
  foo: "ba";
  bar: "r"; }

actual

foo {
  foo: "ba";
  bar: ""; }

This is a regression in 3.1.0. Specs added sass/sass-spec#225.
@xzyfer xzyfer changed the title str-slice returns incorrect value when last $end-at is ommited str-slice returns incorrect value when last $end-at is omitted Jan 7, 2015
This was referenced Jan 7, 2015
Merged
Merged
@xzyfer xzyfer added this to the 3.2 milestone Jan 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xzyfer xzyfer

Labels
Bug - Confirmed Dev - Test Written
Projects
None yet
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

str-slice() $end-at should default to -1 if omitted xzyfer/libsass
1 participant
@xzyfer