Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing special case calc handling for -ms-calc() #842

Closed
xtianus79 opened this issue Jan 16, 2015 · 7 comments · Fixed by #900
Closed

Missing special case calc handling for -ms-calc() #842

xtianus79 opened this issue Jan 16, 2015 · 7 comments · Fixed by #900

Comments

@xtianus79
Copy link

Special case calc handling needs to be implemented for the -ms-calc() function to prevent Incompatible units errors.

foo {
  foo: -ms-calc(100% - 100px);
}

expected

foo {
  foo: -ms-calc(100% - 100px); }

actual

Incompatible units: 'px' and '%'

edited by @xzyfer for clarification

@xzyfer
Copy link
Contributor

xzyfer commented Jan 17, 2015

Can you please create a http://sassmeister.com/ the shows the issue?

@umyeah
Copy link

umyeah commented Feb 18, 2015

I ran into this issue as well when trying to do width: -ms-calc(100% - 100px);

This is happening to me when using libsass 3.1.0 on sassmeister as well as when using node-sass version 2.0.1 (not sure what version of libsass that is using)

@xzyfer
Copy link
Contributor

xzyfer commented Feb 18, 2015

Thanks for the clarification @umyeah. I can confirm that this issue is still present on master.

@xzyfer xzyfer changed the title Error: cannot add or subtract numbers with incompatible units Missing special case handling for calc() Feb 18, 2015
@xzyfer xzyfer changed the title Missing special case handling for calc() Missing special case calc handling for -ms-calc() Feb 18, 2015
@am11
Copy link
Contributor

am11 commented Feb 19, 2015

@umyeah, you can check the version of node-sass and corresponding version of libsass as follow:

CLI usage:

node-sass --help

Code usage:

require('node-sass').info()

node-sass v2.0.1 corresponds to libsass v3.1.0.

@xzyfer
Copy link
Contributor

xzyfer commented Feb 19, 2015

I've confirmed this is still an issue on master.

@xzyfer
Copy link
Contributor

xzyfer commented Feb 22, 2015

Spec added sass/sass-spec#264

@xzyfer xzyfer added this to the 3.2 milestone Feb 22, 2015
@xzyfer
Copy link
Contributor

xzyfer commented Feb 22, 2015

This is fixed and will be in 3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants