Enhancement: Bang whitespace rules should consider !global flag

[bgriffith]

The Space Before Bang and Space After Bang rules consider both the !important and !default flag but should also consider the !global flag too.

This is currently blocked by the Gonzales-pe dependency.

[DanPurdy]

Confirmed as parsing correctly in gonzales 3.2.1

[skyred]

So, we just need to update package.json:

"gonzales-pe": "^3.2.1",

[DanPurdy]

Unfortunately if you do that it will break a lot of other features in sass-lint as it stands. gonzales-pe 3.2.1 includes some breaking features and also some regressions over its previous versions which is why we haven't updated yet.. Once it updates to a stable version with regards to our needs we'll be moving up.

[skyred]

Can we list the road blockers from the upstream below:

1. SCSS regressions from v3.0.0 tonyganch/gonzales-pe#134

What else?

[DanPurdy]

Sorry this issue is specifically for the global flag errors so we wont be listing them here. The blockers are all opened as issues on the gonzales-pe repository if not specified here, we're also in contact with the maintainer of gonzales. Once the issues we know about are resolved we'll then start running our tests again with the new build and hopefully look to upgrade. If you want to see the issues we currently have open then you can see our AST label

[DanPurdy]

This is fixed in sass-lint 1.6.0