Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT REQUEST] - Quote attribute values in selectors #707

Closed
egaudette opened this issue May 12, 2016 · 7 comments
Closed

[ENHANCEMENT REQUEST] - Quote attribute values in selectors #707

egaudette opened this issue May 12, 2016 · 7 comments
Labels

Comments

@egaudette
Copy link

This request is for the enforcement of quotation of attributes in selectors, as such:

Example(s) of enforcement:
default enforcement:

attribute-quotes: 2

explicit enforcement:

  attribute-quotes:
    - 2
    -
      include: true;

The following would be allowed:

input[type="checkbox"] {
    color: #aaa;
}

The following would be disallowed:

input[type=checkbox] {
    color: #aaa;
}


Example(s) of non-enforcement:
default non-enforcement:

attribute-quotes: 0

explicit non-enforcement:

  attribute-quotes:
    - 0
    -
      include: false;

The following would be allowed:

input[type=checkbox] {
    color: #aaa;
}

The following would be disallowed:

input[type="checkbox"] {
    color: #aaa;
}
@bgriffith
Copy link
Member

Thanks for the request 👍 Should be an easy one to implement. Surprised we don't have it covered already!

@bgriffith bgriffith added the rule label May 12, 2016
@egaudette
Copy link
Author

So was I, honestly. I thought I had missed it the first couple of go arounds. I didn't notice it when I checked over the rules, again. If it is nested in a rule that I missed, I apologize.

@DanPurdy
Copy link
Member

@egaudette it's definitely missing should be resolved with #708 if you want to check to see it suits your needs, thanks for the suggestion 👍

@egaudette
Copy link
Author

Sounds good!

Currently I'm using:
"gulp-sass-lint": "1.7.0"

I'm weary of utilizing untested versions, and therefore don't utilize the the wildcard '*' when doing builds:

"gulp-sass-lint": "*"

Is there any sort of email distribution list when there is a new build & distributes of gulp-sass-lint? As those happen, I would like to test that newest version before utilizing it in my Production builds.

@DanPurdy
Copy link
Member

Hmm sorry, we're not usually that organised, we kind of release when we feel we've done enough 😄 we sometimes announce it on Twitter https://twitter.com/DanPurdy0 but that's all i can think of for now.

I would imagine if you check back by the middle of next week you will see that 1.8 is released.

@egaudette
Copy link
Author

Righty oh! Will do.

@egaudette
Copy link
Author

@DanPurdy This is working splendidly. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants