Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add underscore as a special char #14

Merged
merged 2 commits into from
Nov 2, 2021
Merged

feat: Add underscore as a special char #14

merged 2 commits into from
Nov 2, 2021

Conversation

ianperera
Copy link
Contributor

Fixes #13

sators
sators requested changes Nov 2, 2021
View reviewed changes
Copy link
Owner

@sators sators left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for the pull request. Can you add a unit test to ensure this doesn't get overlooked in the future? Thanks!

@ianperera
Copy link
Contributor Author

@sators Thank you for quick reply. I have added unit test.

@ianperera ianperera requested a review from sators November 2, 2021 03:14
@sators sators changed the base branch from master to development November 2, 2021 12:23
@sators sators merged commit f6a28a1 into sators:development Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sators sators sators approved these changes

Assignees

@ianperera ianperera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Underscore ("_") doesn't accept as a special char
2 participants
@ianperera @sators