Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch account should require a device signature #317

Closed
tmpfs opened this issue Feb 3, 2024 · 1 comment · Fixed by #318
Closed

Fetch account should require a device signature #317

tmpfs opened this issue Feb 3, 2024 · 1 comment · Fixed by #318
Assignees

Comments

@tmpfs
Copy link
Collaborator

tmpfs commented Feb 3, 2024

Otherwise revoking a device is not effective as a revoked device could still just fetch all the account data at a later time using just the account key.

To make this possible the device sending the server and private key would need to trust the public key of the other device.

There is an interesting cross-platform bluetooth implementation here:

https://github.com/deviceplug/btleplug

But a quick test yields an abort on MacOS so possibly the better way to communicate between the devices would be an end-to-end encrypted tunnel over the server.

@tmpfs tmpfs self-assigned this Feb 3, 2024
@tmpfs
Copy link
Collaborator Author

tmpfs commented Feb 3, 2024

There is a fix for the abort, described here: deviceplug/btleplug#106 (comment)

@tmpfs tmpfs mentioned this issue Feb 4, 2024
3 tasks
@tmpfs tmpfs closed this as completed in #318 Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant