Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to spec package #6

Closed
tonchis opened this issue Aug 29, 2021 · 1 comment
Closed

Improvements to spec package #6

tonchis opened this issue Aug 29, 2021 · 1 comment

Comments

@tonchis
Copy link

tonchis commented Aug 29, 2021

This is a laundry list of improvements I'd like to make to our spec package. We can extract a few of these bullet points into issues of their own, but so far I'm listing them here so we don't lose track of them.

  • Print the absolute path of the file where a failure happens.
  • Print messages in color.
  • When an example ends report OK, SKIP or FAIL depending on the state. Right now it will print OK even with failures.
  • Print F when reporting a single failure, and then print all failures (with the print_failure function) when calling @reporter.spec_ended, after everything runs.
  • Clean up spec.savi and specs.savi from code we don't need anymore.
@mneumann
Copy link
Contributor

Closing. I have extracted the remaining issues into separate issues #20 and #21

Things already implemented by PR #17:

  • Print messages in color.
  • When an example ends report OK, SKIP or FAIL depending on the state. Right now it will print OK even with failures.
  • Print F when reporting a single failure, and then print all failures (with the print_failure function) when calling @reporter.spec_ended, after everything runs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants