Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support switch iconTheme #26

Closed

Conversation

zzhaolei
Copy link

@zzhaolei zzhaolei commented Jun 7, 2023

Close #25

@zzhaolei
Copy link
Author

zzhaolei commented Jun 7, 2023

@savioserra Hope you can review this PR

@savioserra
Copy link
Owner

savioserra commented Aug 8, 2023

Hey @zzhaolei, thank you very much for this pull request! The only thing that stands out to me is that we should check if iconTheme is undefined before making that change, so we don’t have to always specify icon themes. I can make this change if you want. :)

@zzhaolei zzhaolei force-pushed the support-switch-icon-theme branch from 5af310b to 6cbe5af Compare August 13, 2023 03:24
@zzhaolei
Copy link
Author

zzhaolei commented Aug 13, 2023

The only thing that stands out to me is that we should check if iconTheme is undefined before making that change, so we don’t have to always specify icon themes. I can make this change if you want. :)

I updated the code. If iconTheme is not set, now behaves the same as before.

@zzhaolei
Copy link
Author

Hey, Can you merge this? @savioserra

@zzhaolei
Copy link
Author

friendly ping @savioserra

@zzhaolei
Copy link
Author

Hello, can you merge this PR, please?

@zzhaolei zzhaolei closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Also switch icon theme
2 participants