From 83d0831a94a658090ccf2150723646372b0bdbc6 Mon Sep 17 00:00:00 2001 From: Niels Buus Date: Fri, 1 Jul 2016 17:20:51 +0200 Subject: [PATCH 1/2] Restore support for cookies when using custom headers This commit configures cookies AFTER configuring headers. This is necessary because the header configuration method resets existing headers, including cookies. --- lib/savon/request.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/savon/request.rb b/lib/savon/request.rb index 668bc9c3..1b3a1189 100644 --- a/lib/savon/request.rb +++ b/lib/savon/request.rb @@ -72,9 +72,9 @@ class SOAPRequest < HTTPRequest def build(options = {}) configure_proxy - configure_cookies options[:cookies] configure_timeouts configure_headers options[:soap_action], options[:headers] + configure_cookies options[:cookies] configure_ssl configure_auth configure_redirect_handling From 78dd78b036c90fe7f04124fdb63c2c909ec0edc0 Mon Sep 17 00:00:00 2001 From: Niels Buus Date: Wed, 13 Jul 2016 18:08:58 +0200 Subject: [PATCH 2/2] Update README.md --- README.md | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/README.md b/README.md index e4593ad1..6cb59aea 100644 --- a/README.md +++ b/README.md @@ -1,3 +1,13 @@ +# NOTICE: This is a fork of savonrb/savon + +It's forked because savonrb has a bug when headers and sessions are combined, and even though we have opened a pull request for a fix on the official repo, it seems that: + +![Nobody cares](https://cdn.meme.am/instances/500x/22118345.jpg) + +Because of that, we are using this fork. Hopefully not for long, as the savon/rconomic duo should be retired from our systems in favor of using E-conomic's shiny new JSON/REST API. + +--- + # Savon Heavy metal SOAP client