New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve types for filters::SearchFilter #13

Open

sbdchd opened this issue Sep 8, 2021 · 0 comments

Owner

sbdchd commented Sep 8, 2021

Specifically

def get_search_fields(self, view: APIView, request: Request) -> Any: ...
# and
def must_call_distinct(self, queryset: QuerySet[Any], search_fields: Any) -> bool: ...

Instead can be:

def get_search_fields(self, view: APIView, request: Request) -> Sequence[str] | None: ...
# and
def must_call_distinct(self, queryset: QuerySet[Any], search_fields: Sequence[str]) -> bool: ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment